xiaoxiang781216 commented on a change in pull request #2621:
URL: https://github.com/apache/incubator-nuttx/pull/2621#discussion_r555205073
##########
File path: drivers/syslog/Kconfig
##########
@@ -102,15 +102,59 @@ config SYSLOG_TIMESTAMP
---help---
Prepend timestamp to syslog message.
+choice
+ prompt "Timestamp format"
+ depends on SYSLOG_TIMESTAMP
+
+config SYSLOG_TIMESTAMP_SYSTIME
+ bool "System time"
+ default y
+ ---help---
+ Use the system timer for timestamp.
+
config SYSLOG_TIMESTAMP_REALTIME
- bool "Use wall-clock for syslog timestamp"
+ bool "Wall-clock time"
default n
- depends on SYSLOG_TIMESTAMP
---help---
Use wall-clock (CLOCK_REALTIME) for timestamp. By default,
CLOCK_MONOTONIC, if enabled, will be used or the system timer
is not.
+config SYSLOG_TIMESTAMP_FORMATED
Review comment:
I mean that:
1. Remove SYSLOG_TIMESTAMP_SYSTIME
2. Move SYSLOG_TIMESTAMP_FORMATED out of choice
Basically, keep SYSLOG_TIMESTAMP and SYSLOG_TIMESTAMP_REALTIME as before,
and add a new option SYSLOG_TIMESTAMP_FORMATED.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
