fjpanag opened a new pull request #2621:
URL: https://github.com/apache/incubator-nuttx/pull/2621


   ## Summary
   Adds the ability to have formatted timestamps in syslog, using the standard 
C date specifiers (`strftime`).
   
   ## Impact
   The default formatting remains as is, so there should be no impact on 
current projects.
   
   ## Testing
   Tested the patch on NuttX-v10.0.1 on custom STM32F4-based board, and works 
as expected.  
   I do plan to do more extensive testing on all possible configurations of 
syslog timestamping.
   
   ---
   
   The current implementation does not look very elegant or efficient to me.  
   I think it can be improved. Maybe a `lib_strftime` is needed? Maybe 
`localtime` can be avoided?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to