yamt commented on a change in pull request #2064: URL: https://github.com/apache/incubator-nuttx/pull/2064#discussion_r514616886
########## File path: include/sys/types.h ########## @@ -188,6 +188,9 @@ typedef intptr_t ptrdiff_t; typedef uint16_t wchar_t; #endif +#if defined(__WCHAR_WIDTH__) && __WCHAR_WIDTH__ != 16 +#error __WCHAR_WIDTH__ should be 16 Review comment: do you mean to make this #warnings instead of #error? i guess the compiler we are using for arm is configured for linux and thus `__WCHAR_WIDTH__` = 32. anyway 32 is commonly used for modern OSes except windows. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org