xiaoxiang781216 commented on a change in pull request #2064:
URL: https://github.com/apache/incubator-nuttx/pull/2064#discussion_r512490191
##########
File path: tools/Config.mk
##########
@@ -531,3 +531,22 @@ else
ARCHXXINCLUDES += ${shell $(INCDIR) -s "$(CC)"
$(TOPDIR)$(DELIM)include$(DELIM)cxx}
endif
ARCHXXINCLUDES += ${shell $(INCDIR) -s "$(CC)" $(TOPDIR)$(DELIM)include}
+
+# If CC_TYPE is not set, try to guess.
+ifeq ($(CC_TYPE),)
Review comment:
it isn't good to place toolchain specific flag here, the better place is
Toolchain.defs or Make.defs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
