Ouss4 commented on a change in pull request #1958:
URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r511638935
##########
File path: arch/xtensa/Kconfig
##########
@@ -91,6 +91,11 @@ config XTENSA_IMEM_REGION_SIZE
range 0x2000 0x28000
default 0x28000
+config XTENSA_IMEM_PROCFS
+ bool "Internal memory PROCFS support"
+ default n
+ depends on XTENSA_USE_SEPERATE_IMEM && !DISABLE_MOUNTPOINT && FS_PROCFS
&& FS_PROCFS_REGISTER
Review comment:
I think this is just a Github glitch. You can see the file here:
https://github.com/apache/incubator-nuttx/blob/7b1234bb38379c5ce28c3ffefa82c4f6b4b42e0d/arch/xtensa/Kconfig
##########
File path: arch/xtensa/Kconfig
##########
@@ -81,6 +81,16 @@ config XTENSA_CP_INITSET
is provided by CONFIG_XTENSA_CP_INITSET. Each bit corresponds
to one
coprocessor with the same bit layout as for the CPENABLE
register.
+config XTENSA_USE_SEPERATE_IMEM
Review comment:
Done.
##########
File path: arch/xtensa/src/common/xtensa_createstack.c
##########
@@ -73,6 +73,18 @@
#define STACK_ALIGN_DOWN(a) ((a) & ~STACK_ALIGN_MASK)
#define STACK_ALIGN_UP(a) (((a) + STACK_ALIGN_MASK) & ~STACK_ALIGN_MASK)
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
Review comment:
Done
##########
File path: arch/xtensa/src/esp32/esp32_allocateheap.c
##########
@@ -77,8 +77,13 @@
void up_allocate_heap(FAR void **heap_start, size_t *heap_size)
{
board_autoled_on(LED_HEAPALLOCATE);
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
