[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

[GitBox]

xiaoxiang781216 commented on a change in pull request #2042:
URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508276708



##########
File path: arch/arm/src/cxd56xx/cxd56_irq.c
##########
@@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3];
 
 const uint32_t g_cpu_intstack_top[CONFIG_SMP_NCPUS] =
 {
-  (uint32_t)g_intstack_alloc + INTSTACK_SIZE,
+  (uint32_t)g_intstack_alloc + INTSTACK_SIZE - 8,

Review comment:
       And we found that SMP_STACK_SIZE is bigger than SMP_STACK_TOP by 8bytes:
   
![image](https://user-images.githubusercontent.com/18066964/96555504-75076c00-12ea-11eb-90b3-56a22b4e9431.png)
   Which make adj_stack_ptr mismatch with adj_stack_size:
   
![image](https://user-images.githubusercontent.com/18066964/96555406-51dcbc80-12ea-11eb-8b48-195dd9721903.png)
   And finally report the false stack colorize information here:
   
![image](https://user-images.githubusercontent.com/18066964/96555642-9c5e3900-12ea-11eb-8dac-9170706e0378.png)
   so to avoid the similar issue happen again, it's better to fix the problem 
from root by removing -8 at all.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org