Donny9 commented on pull request #2039:
URL: https://github.com/apache/incubator-nuttx/pull/2039#issuecomment-712571248


   > 
   > 
   > I also like the idea of unifying interfaces and reducing the need to 
repeat it across each sensor. But I worry if this is really a general sensor 
solution. Mainly since this introduces an intermediate buffering which may not 
be desired (due to space and added processing, in contrast to simply have the 
lower half write into the buffer passed by the caller). Maybe this buffer could 
optionally be disabled somehow.
   
   The buffer is originally designed to solve the problem that the upper 
application fails to read sensor data timely due to jamming, and it will bring 
some protection. We suggest that the length of this buffer should be 2-3 sensor 
events for a sensor with a high sampling rate. If the buffer is low sampling 
rate, it can be set to 1 sensor event. 
   
   The events generated in this sensor model are all active and not read by the 
read function, because the read function is sometimes slow, which can cause 
performance problems for application .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to