patacongo commented on pull request #1602: URL: https://github.com/apache/incubator-nuttx/pull/1602#issuecomment-680102911
> > > > This change MUST not come into master UNLESS all simulator specific changes outside of arch/sim and boards/sime are removed. The common OS must not be contaminated with platform-specific code. > > I agree. > > The platform independent logic is supposed to remain platform independent!! I wonder if there is some design alternative that would eliminate the need for this coupling. It would be good if we could bring this code in, but we do have to enforce the OS modularity. There are other examples where we had to implement special features to support specific platforms or hardware, but we did these things by extending interfaces and configuration options. For example, we added the capabilities method to the SDIO interface (included/nuttx/sdio.h). I am not proposing that as a solution and would not advocate a hack just to avoid the SIM dependency. We need to do things right. There are not comments added to the code to explain why you thought this was necessary. So it is hard to suggest alternatives. Comments are good! Comments are your friends! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
