patacongo commented on a change in pull request #1602:
URL: https://github.com/apache/incubator-nuttx/pull/1602#discussion_r475093949
##########
File path: sched/task/task_setup.c
##########
@@ -593,6 +598,11 @@ static inline int nxtask_setup_stackargs(FAR struct
task_tcb_s *tcb,
stackargv[argc + 1] = NULL;
tcb->argv = stackargv;
+#ifdef CONFIG_SIM_PREEMPTIBLE
+ up_setup_args_context(tcb->cmn.xcp.ucontext_buffer, tcb->cmn.start, argc,
Review comment:
Then this change must NOT be merged into master. The integrity of the
OS modularity is far, far, far most important than your change.
THIS MUST NOT BE MERGED. IT VIOLATES CORE ARCHITECTURAL PRINCIPLES OF THE
OS. I will chnage the PR to a draft so that it is not accidentally merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
