Fix-Point commented on PR #17517: URL: https://github.com/apache/nuttx/pull/17517#issuecomment-3673349877
> > I need to emphasize that this is not an optimization at all, but a completely different implementation. Please let the community judge its correctness, not just your own ideas. Why are some guy in such a hurry? > > @Fix-Point There are various implementation approaches for **hrtimer**, but the benefit it delivers to business users is a **high-precision timer.** We need to examine this issue from the perspective of applications and business stakeholders—otherwise, any implementation would merely be an exercise in self-indulgence for developers. Such implementations must generate tangible business value, which is why I use the term "optimization". > > Additionally, I recommend that you keep a close eye on community developments. I think that professional developers like you will do more to help independent developers in the community enhance their technical capabilities. This will also help you identify if there are others working on the same initiatives as you. > > Furthermore, while I cannot speak on behalf of the entire community, I sincerely apologize if any of my remarks have caused offense. That said, I will still merge this pull request. It is more concise in design and demonstrably improves timer precision under the default AMP configuration. I believe there must be a consensus on respecting objective facts and 实事求是 (seeking truth from facts). What is good should be acknowledged as good, and what is not should be recognized as such. Good work deserves encouragement, while shortcomings should be improved. @wangchdo hrtimer is completely unusable for users (https://github.com/apache/nuttx/issues/17567). However, his modifications to the alarm functionality are quite excellent, and they might help me optimize some of the inelegant code implementations (such as `hrtimer_reprogram`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
