xiaoxiang781216 commented on PR #17276: URL: https://github.com/apache/nuttx/pull/17276#issuecomment-3525852574
> @xiaoxiang781216 @Fix-Point This looks similar to the hrtimer driver I planned to add in my PR #17065, which was intended to provide access to the hardware timer count. > > However, @xiaoxiang781216 mentioned in that PR that adding a new timer driver is not allowed in NuttX, so I removed the implementation, and reimplemented the sched/hrtimer based on the exsiting timer driver. > > Your PR to introcude ClockDevice makes me feel confused about the criteria for what kind of functionality is acceptable to add to NuttX... This is still oneshot driver, but change the tick callback to count callback since the tick version lose the accuary of hardware timer, other major improvement include: 1. Provide the high efficient implementation of count<->tick and count<->timespec conversion in framework to simplify the driver developement. 2. Modify all arch general timer to utlize the new improvement, but still support the old interface but this change doesn't add any new arch up_xxx function. All above improvement isn't related to hrtimer at all, both tick and tickless mode can get the benifit(performance improvent and driver simplication) from this PR. The new hrtimer implementation doesn't add any new arch up_xxx function too, which continue use up_(alarm|timer)_start/up_(alarm|timer)_cancel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
