xiaoxiang781216 commented on a change in pull request #346:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/346#discussion_r471202071
##########
File path: examples/wget/Kconfig
##########
@@ -12,11 +12,18 @@ config EXAMPLES_WGET
if EXAMPLES_WGET
+config EXAMPLES_WGET_STACKSIZE
+ int "wget stack size"
+ default 2048
+ ---help---
+ Stack size of "wget" command. If you use SSL connection,
+ you should increase this value around 8096.
+
config EXAMPLES_WGET_URL
string "File URL"
default ""
---help---
- The URL of the file to get
+ The URL of the file to get
config EXAMPLES_WGET_NOMAC
Review comment:
I mean change to:
```
config EXAMPLES_WGET_NOMAC
depends on !NSH_NETINIT
```
It doesn't make sense to let user select mac related option if NSH_NETINIT
turn on because your code skip all related code in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
