xiaoxiang781216 commented on a change in pull request #346: URL: https://github.com/apache/incubator-nuttx-apps/pull/346#discussion_r471201267
########## File path: examples/wget/Kconfig ########## @@ -12,11 +12,18 @@ config EXAMPLES_WGET if EXAMPLES_WGET +config EXAMPLES_WGET_STACKSIZE + int "wget stack size" + default 2048 + ---help--- + Stack size of "wget" command. If you use SSL connection, + you should increase this value around 8096. + config EXAMPLES_WGET_URL Review comment: But your patch don't reference EXAMPLES_WGET_URL anymore and the code return -1 if user don't pass a URL. So please make your code and Kconfig consistent with each other. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org