xiaoxiang781216 commented on code in PR #17043: URL: https://github.com/apache/nuttx/pull/17043#discussion_r2370848045
########## sched/sched/sched_suspendscheduler.c: ########## @@ -68,6 +68,12 @@ void nxsched_suspend_scheduler(FAR struct tcb_s *tcb) return; } +#ifdef CONFIG_TASK_STACK_OVERFLOW_CHECK + /* Check for stack overflow */ + + DEBUGASSERT(!up_check_tcbstack_overflow(tcb)); Review Comment: we can add up_checktcb_stack_limit and change up_checktcb_stack to macro by simply forwarding to up_checktcb_stack_limit, so both case can share the same implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org