wangchdo commented on code in PR #17043:
URL: https://github.com/apache/nuttx/pull/17043#discussion_r2370761056


##########
sched/sched/sched_suspendscheduler.c:
##########
@@ -68,6 +68,12 @@ void nxsched_suspend_scheduler(FAR struct tcb_s *tcb)
       return;
     }
 
+#ifdef CONFIG_TASK_STACK_OVERFLOW_CHECK
+  /* Check for stack overflow */
+
+  DEBUGASSERT(!up_check_tcbstack_overflow(tcb));

Review Comment:
   @xiaoxiang781216 
   
   We can also consider to implement a new api to check interrupt stack 
overflow based on my patch.
   You know there are two existing functions:
   `up_check_tcbstack`;  `up_check_intstack`
   
   
   We can introduce two functions: 
   
   `up_check_tcbstack_overflow` `up_check_intstack_overflow`
   
   to check task and interrupt stack over flow separately, using the same low 
lever stack check function just as `up_check_intstack` uses the same low level 
stack check function as `up_check_tcbstack`
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to