raiden00pl commented on code in PR #17007: URL: https://github.com/apache/nuttx/pull/17007#discussion_r2354420487
########## arch/arm/src/stm32h5/stm32_adc.h: ########## @@ -498,8 +521,8 @@ extern "C" struct adc_dev_s; struct adc_dev_s *stm32h5_adc_initialize(int intf, - const uint8_t *chanlist, - int nchannels); + struct stm32_adc_channel_s *chanlist + , int nchannels); Review Comment: > My goal with this pull request was to do 2 things primarily: Add support for differential ADC inputs. Add support for the ADC Watchdogs. I'm adding only code for watchdog1 because the upper level driver does not currently support more than 1 watchdog with the ioctls available. That's another problem with this PR. One PR and one commit introduces two different, unrelated changes, which makes reviewing them more difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
