jlaitine commented on code in PR #16673:
URL: https://github.com/apache/nuttx/pull/16673#discussion_r2215165977
##########
sched/sched/sched_setpriority.c:
##########
@@ -223,29 +230,30 @@ static inline void nxsched_running_setpriority(FAR struct
tcb_s *tcb,
/* A context switch will occur. */
#ifdef CONFIG_SMP
- if (tcb->cpu != this_cpu() &&
+ int cpu = this_cpu();
+ if (tcb->cpu != cpu &&
tcb->task_state == TSTATE_TASK_RUNNING)
{
- struct reprioritize_arg_s arg;
+ struct reprioritize_arg_s *arg = &g_reprioritize_arg[cpu];
Review Comment:
An alternative would be setting the priority directly to the tcb, and then
making an smp schedule call to the other CPU. This should work just fine; if
the other CPU happens to reschedule before the call is executed on the other
CPU, the priority will be set properly anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
