xiaoxiang781216 commented on code in PR #16719:
URL: https://github.com/apache/nuttx/pull/16719#discussion_r2203269181


##########
arch/arm64/src/zynq-mpsoc/zynq_serial.c:
##########
@@ -1024,6 +1024,9 @@ static void zynq_uart_txint(struct uart_dev_s *dev, bool 
enable)
 {
   struct zynq_uart_port_s *port = (struct zynq_uart_port_s *)dev->priv;
   struct zynq_uart_config *config = &port->config;
+  irqstate_t flags;
+
+  flags = enter_critical_section();

Review Comment:
   let's add spinlock to zynq_uart_port_s and use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to