jlaitine commented on PR #16673: URL: https://github.com/apache/nuttx/pull/16673#issuecomment-3052220420
@hujun260 ; I changed the erroneous places which you pointed out, I also added one patch on the top, which tries to address your concern of moving tasks back-and-forth when sched-locked task is running on one tcb. Could you please check if that makes sense? My intention is to prevent tasks repeatedly being assigned to a CPU, which is running a locked task. I think the most appropriate way to deal with that is to treat a locked task as if it had the highest possible priority; In other words, don't select that CPU for other tasks. When the task exists schedlock, it will anyhow re-assign the tasks to the CPUs. As you suggested, the vector of assigned task lists could be changed into simple vector of "g_running_task[CONFIG_SMP_NCPUS]" or such, because now the assigned tasks list only keeps the idle task in the end and one runnning task in front of that. I'd like to leave that to another PR, as it is only a cleanup and wouldn't change the functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
