xiaoxiang781216 commented on code in PR #16677:
URL: https://github.com/apache/nuttx/pull/16677#discussion_r2186492045
##########
drivers/input/touchscreen_upper.c:
##########
@@ -149,6 +150,11 @@ static int touch_open(FAR struct file *filep)
filep->f_priv = openpriv;
nxmutex_unlock(&upper->lock);
+ if (lower->open)
Review Comment:
let's move the unrelated change to new patch
##########
drivers/input/Kconfig:
##########
@@ -85,6 +85,33 @@ config INPUT_TOUCHSCREEN
bool
default n
+if INPUT_TOUCHSCREEN && VIDEO_FB
+
+config INPUT_TOUCHSCREEN_SWAPXY
Review Comment:
let's add field to touch_lowerhalf_s, so the multiple touch driver could get
the different config.
##########
include/nuttx/input/touchscreen.h:
##########
@@ -235,6 +236,7 @@ struct touch_lowerhalf_s
{
uint8_t maxpoint; /* Maximal point supported by the touchscreen
*/
FAR void *priv; /* Save the upper half pointer */
+ struct fb_videoinfo_s vinfo;
Review Comment:
let's change to xres/yres and filled by board file to avoid couple touch
driver with fb, since the display may use lcd driver framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
