acassis commented on PR #16605: URL: https://github.com/apache/nuttx/pull/16605#issuecomment-3000483304
@EliasJRH cool! Thanks for your contribution, please fix these issues detected by the "checkpatch.sh" Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:359:78: error: Block comments have different lengths Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:1:77: error: Block comments have different lengths Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:2:1: error: Relative file path does not match actual file Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:3:3: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:7:3: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:25:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:126:34: error: Operator/assignment must be preceded with whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:128:87: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:144:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:154:3: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:157:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:158:35: error: Operator/assignment must be preceded with whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:158:52: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:158:1: error: Insufficient indentation line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:160:31: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:162:2: error: Bad right brace alignment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:162:3: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:175:3: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:179:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:180:51: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:185:2: error: Missing whitespace after keyword Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:185:12: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:191:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:197:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:203:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:209:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:215:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:221:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:233:75: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:237:2: error: C++ style comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:237:5: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:238:29: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:240:3: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:248:69: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:256:3: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:263:39: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:264:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:265:86: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:265:87: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:278:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:283:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:288:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:289:22: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:485:50: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:486:58: error: Dangling whitespace at the end of line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:494:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:498:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:499:50: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:504:38: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:505:35: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:508:11: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:512:7: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:514:79: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:515:60: error: Block comment terminator must be on a separate line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:515:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:519:7: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:520:1: error: Missing blank line before comment found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:520:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:527:7: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:530:8: error: C++ style comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:530:84: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:532:7: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:535:8: error: C++ style comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:535:84: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:538:5: error: Right brace must be followed by a blank line Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:541:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:562:81: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:566:2: error: C++ style comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:567:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:570:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:572:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:575:2: error: Bad left brace alignment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:612:19: error: C++ style comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:612:22: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:628:1: error: Missing blank line after comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:629:2: error: C++ style comment Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:629:11: error: Mixed case identifier found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:645:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:656:138: error: Long line found Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:657:1: error: Blank line contains whitespace Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:659:1: error: Blank line contains whitespace /home/runner/work/nuttx/nuttx/nuttx/drivers/sensors/l86xxx_uorb.c:494: sattelite ==> satellite Error: /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/sensors/l86xxx.h:46:13: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/sensors/l86xxx.h:57:13: error: Left bracket not on separate line Error: /home/runner/work/nuttx/nuttx/nuttx/include/nuttx/sensors/l86xxx.h:84:82: error: Long line found I think you forgot to run the checkpatch.sh before opening the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org