xiaoxiang781216 commented on code in PR #16463:
URL: https://github.com/apache/nuttx/pull/16463#discussion_r2118912869


##########
cmake/nuttx_kconfig.cmake:
##########
@@ -56,6 +56,7 @@ function(nuttx_export_kconfig_by_value kconfigfile config)
       break()
     endif()
   endforeach()
+  message(STATUS "Name: ${Name}, Value: ${Value}")

Review Comment:
   don't add your debugging code into the official patch



##########
drivers/dma/dma_align_manager.c:
##########
@@ -0,0 +1,30 @@
+#include <nuttx/dma/dma_align_manager.h>
+#include <sys/types.h>
+int dma_align_manager_init(struct dma_align_manager_s *manager,struct 
dma_align_manager_init_s *initcfg)

Review Comment:
   merge the alignment code into sdmmc common code, the code is too simple to 
become a manager.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to