PetervdPerk-NXP commented on code in PR #16463: URL: https://github.com/apache/nuttx/pull/16463#discussion_r2118858387
########## drivers/mmcsd/mmcsd_sdio.c: ########## Review Comment: Please split out the mmcsd/sdio, fat changes into a seperate PR. The impact is quite high and needs to be tested on a lot of systems. Overall I think the naming of the dma_align_manager_init is too generic whilst only tested on mmcsd/sdio please consider to rename it. Also consider to make the align_manager work with a pre-allocated pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
