xiaoxiang781216 commented on code in PR #16365:
URL: https://github.com/apache/nuttx/pull/16365#discussion_r2086757475
##########
boards/avr/avrdx/breadxavr/Kconfig:
##########
@@ -7,7 +7,7 @@ if ARCH_BOARD_AVRDX_BREADXAVR
config BREADXAVR_BUTTONS_DRIVER
bool "Enable button input driver for GPIO pins"
- depends on (INPUT_BUTTONS && INPUT_BUTTONS_LOWER &&
BOARD_EARLY_INITIALIZE)
+ depends on (INPUT_BUTTONS && INPUT_BUTTONS_LOWER &&
BOARD_EARLY_INITIALIZE && AVR_AVRDX_GPIO_ISR_MUX )
Review Comment:
`depends on INPUT_BUTTONS && INPUT_BUTTONS_LOWER && BOARD_EARLY_INITIALIZE
&& AVR_AVRDX_GPIO_ISR_MUX`
##########
boards/avr/at32uc3/avr32dev1/configs/nsh/defconfig:
##########
@@ -40,3 +40,7 @@ CONFIG_SYSTEM_NSH=y
CONFIG_TASK_NAME_SIZE=0
CONFIG_USART1_BAUD=57600
CONFIG_USART1_SERIAL_CONSOLE=y
+# Prevent the linker from removing unused sections until the linker script
+# is checked to verify that it makes sure to preserve sections which appear
+# unreferenced but must be present in the binary
+CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n
Review Comment:
need change to:
```
# CONFIG_DEBUG_OPT_UNUSED_SECTIONS is not set
```
and move before line 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
