acassis commented on code in PR #16365: URL: https://github.com/apache/nuttx/pull/16365#discussion_r2086382299
########## boards/avr/at90usb/teensy-2.0/configs/usbmsc/defconfig: ########## @@ -55,3 +55,7 @@ CONFIG_USBMSC_PRODUCTSTR="USBdev Storage" CONFIG_USBMSC_REMOVABLE=y CONFIG_USBMSC_SCSI_STACKSIZE=512 CONFIG_USBMSC_VERSIONNO=0x0399 +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/amber/configs/hello/defconfig: ########## @@ -36,3 +36,7 @@ CONFIG_STDIO_BUFFER_SIZE=0 CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_BAUD=38400 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/mega1284p-xplained/configs/nsh/defconfig: ########## @@ -37,3 +37,7 @@ CONFIG_START_YEAR=2015 CONFIG_SYSTEM_NSH=y CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/moteino-mega/configs/nsh/defconfig: ########## @@ -37,3 +37,7 @@ CONFIG_START_YEAR=2015 CONFIG_SYSTEM_NSH=y CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/arduino-mega2560/configs/nsh/defconfig: ########## @@ -38,3 +38,7 @@ CONFIG_SYSTEM_NSH=y CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_BAUD=38400 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/moteino-mega/configs/hello/defconfig: ########## @@ -33,3 +33,7 @@ CONFIG_START_DAY=31 CONFIG_START_YEAR=2015 CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/mega1284p-xplained/configs/hello/defconfig: ########## @@ -33,3 +33,7 @@ CONFIG_START_DAY=31 CONFIG_START_YEAR=2015 CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/at32uc3/mizar32a/configs/nsh/defconfig: ########## @@ -37,3 +37,7 @@ CONFIG_START_YEAR=2010 CONFIG_SYSTEM_NSH=y CONFIG_TASK_NAME_SIZE=0 CONFIG_USART1_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/at90usb/teensy-2.0/configs/hello/defconfig: ########## @@ -35,3 +35,7 @@ CONFIG_START_YEAR=2011 CONFIG_TASK_NAME_SIZE=0 CONFIG_USART1_BAUD=38400 CONFIG_USART1_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/atmega/arduino-mega2560/configs/hello/defconfig: ########## @@ -39,3 +39,7 @@ CONFIG_STDIO_BUFFER_SIZE=0 CONFIG_TASK_NAME_SIZE=0 CONFIG_USART0_BAUD=38400 CONFIG_USART0_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/at32uc3/avr32dev1/configs/nsh/defconfig: ########## @@ -40,3 +40,7 @@ CONFIG_SYSTEM_NSH=y CONFIG_TASK_NAME_SIZE=0 CONFIG_USART1_BAUD=57600 CONFIG_USART1_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: Better to add this info in other place, defconfig are not supposed to have comments, because other user can re-create it the comments will be lost, also setting "CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n" is not was kconfig disables an option, this config was edited manually, this is not recommended ########## boards/avr/at90usb/micropendous3/configs/hello/defconfig: ########## @@ -35,3 +35,7 @@ CONFIG_START_YEAR=2011 CONFIG_TASK_NAME_SIZE=0 CONFIG_USART1_BAUD=38400 CONFIG_USART1_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto ########## boards/avr/at90usb/teensy-2.0/configs/nsh/defconfig: ########## @@ -39,3 +39,7 @@ CONFIG_SYSTEM_NSH=y CONFIG_TASK_NAME_SIZE=0 CONFIG_USART1_BAUD=38400 CONFIG_USART1_SERIAL_CONSOLE=y +# Prevent the linker from removing unused sections until the linker script +# is checked to verify that it makes sure to preserve sections which appear +# unreferenced but must be present in the binary +CONFIG_DEBUG_OPT_UNUSED_SECTIONS=n Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
