shtirlic commented on code in PR #16331:
URL: https://github.com/apache/nuttx/pull/16331#discussion_r2076889003
##########
arch/arm/src/rp23xx/rp23xx_serial.c:
##########
@@ -914,16 +914,21 @@ static void up_txint(struct uart_dev_s *dev, bool enable)
* interrupts disabled (note this may recurse).
*/
+# ifdef CONFIG_SMP
Review Comment:
Because it's only needed in SMP version to workaround `uart_xmitchars` in
`serial_io.c`, for non SMP there is already whole section critical. We can
make it more readable like this, what you think?
```c
# ifdef CONFIG_SMP
spin_unlock_irqrestore(&priv->lock, flags);
uart_xmitchars(dev);
flags = spin_lock_irqsave(&priv->lock);
# else
uart_xmitchars(dev);
# endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
