shtirlic commented on code in PR #16331:
URL: https://github.com/apache/nuttx/pull/16331#discussion_r2076785587
##########
arch/arm/src/rp23xx/rp23xx_serial.c:
##########
@@ -914,16 +914,21 @@ static void up_txint(struct uart_dev_s *dev, bool enable)
* interrupts disabled (note this may recurse).
*/
+# ifdef CONFIG_SMP
Review Comment:
I think it's because the whole section should be in critical section until
the end of the function, in SMP config it's more complicated since
`serial_io.c` already have `enter_critical section` in the code, so they added
unlock before it and lock after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
