gpoulios commented on code in PR #16309:
URL: https://github.com/apache/nuttx/pull/16309#discussion_r2072957899
##########
drivers/misc/optee.c:
##########
@@ -653,5 +1849,47 @@ static int optee_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
int optee_register(void)
{
+#ifdef CONFIG_DEV_OPTEE_SMC64
Review Comment:
Not really, the point of this was/is to test through kernel thread context,
or otherwise without bringing up any apps/userspace.
Btw I see you marked the block containing also the compatibility checks.
Perhaps by accident? The compatibility checks I think are even more so needed
there to avoid registering the driver altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
