gpoulios commented on code in PR #16309:
URL: https://github.com/apache/nuttx/pull/16309#discussion_r2072941504
##########
drivers/misc/Kconfig:
##########
@@ -43,31 +43,66 @@ choice
prompt "Select OP-TEE dev implementation"
default DEV_OPTEE_NONE
---help---
- There are two implementations of optee server,
+ There are three implementations of optee server,
one is soft tee server which does not distinguish
between secure and non-secure states and uses socket
communication,
- and the other is teeos which runs in the secure state of
- the cpu and uses rpmsg cross-core communication.
+ and the other two is teeos which runs in the secure state of
+ the cpu and uses either rpmsg cross-core communication or ARM64
SMCs.
config DEV_OPTEE_LOCAL
bool "OPTEE Local Socket Support"
depends on NET_LOCAL
+ depends on LIBC_MEMFD_SHMFS
depends on ALLOW_BSD_COMPONENTS
config DEV_OPTEE_RPMSG
bool "OP-TEE RPMSG Socket Support"
depends on NET_RPMSG
+ depends on LIBC_MEMFD_SHMFS
+ depends on ALLOW_BSD_COMPONENTS
+
+config DEV_OPTEE_SMC64
Review Comment:
I don't know and I have a dependencies on arch/arm64 for `arm64_smccc_res`
and other parts of the code, but the biggest reason I did it this way, is that
I can't test arm32 (don't have a board/setup). Hence I opted for `_SMC64` and
dependency on `ARCH_ARM64` to make things clear for everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
