raiden00pl commented on issue #16248: URL: https://github.com/apache/nuttx/issues/16248#issuecomment-2823296652
Please make the GDMA implementation as similar to the rest of DMA implementations in STM32 as possible: similar API and all work that belongs to DMA driver is done in DMA driver. Remember that if GDMA is used in the STM32H7R family, then one day your implementation may be ported to STM32H7 as well and then compatibility is of great importance. Also porting other peripherals to STM32H5 that use the old DMA API will be much easier when the interface is similar. All DMA implementations in the STM32 families use a very similar API and it should remain so even if it complicates the implementation of the DMA driver itself. If you look at STM32H7 and the rest of the STM32's, even though they use different DMA implementations, the general outline of the API and its usage is very similar to the rest. In the old days when STM32H7 was still new chip, it was more visible than now: MDMA, BDMA, DMAMUX, wtf, but I put some effort to make the API and its use as close as possible to previous implementations. So I'm definitely for the second option :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
