simbit18 commented on code in PR #16257:
URL: https://github.com/apache/nuttx/pull/16257#discussion_r2062623466
##########
drivers/video/Kconfig:
##########
@@ -56,6 +56,102 @@ config VIDEO_FB_NPOLLWAITERS
depends on VIDEO_FB
default 2
+config VIDEO_FB_SPLASHSCREEN
+ bool "Enable Splashscreen when Framebuffer Driver is registered"
+ depends on VIDEO_FB
+ default n
+ ---help---
+ This feature allows a splashscreen image to be displayed during the
+ Framebuffer device driver register function. It provides the
following
+ functionality:
+ - Choice of 80x80, 160x160 or 320x320 default "NX" logos
+ - Alternative "out-of-tree" image as splashscreen
+ - Configurable background colour (default black)
+ - Bit-per-pixel choice (32/24/16/8/Greyscale/Mono) to suit the
LCD used
+ - Splashscreen can be set to remain displayed for 'n' seconds
('n' can be 0)
+ - Splashscreen can be cleared (to black) once framebuffer
device register is
+ complete
+ - Python "splashscreen_converter.py" tool (in NuttX tools
directory) can be used
+ to create custom splashscreens - note the tool restricts the
number of colours
+ to 256.
+
+
+if VIDEO_FB_SPLASHSCREEN
+
+menu "Splashscreen Image Selection and Configuration"
+
+choice
+ prompt "Select Splashscreen Image Source"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO
+ bool "Use default NuttX NX Logo"
+
+config VIDEO_FB_SPLASHSCREEN_CUSTOM
+ bool "Use Custom file as splashscreen"
+ ---help---
+ This must be a compiled C source file, such as fb_splash.o, created
+ as a c src file using the splashscreen_converter.py Python script,
+ available in the nuttx/tools directory, and compiled as part of the
+ build.
+ Typically this would be a source file of an out-of-tree custom board.
+
+endchoice
+
+choice
+ prompt "Select NXlogo bitmap size to use"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO_160
+ depends on VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO_320
+ bool "320x320 pixels"
Review Comment:
remove spaces and add a tab (line 107)
##########
drivers/video/Kconfig:
##########
@@ -56,6 +56,102 @@ config VIDEO_FB_NPOLLWAITERS
depends on VIDEO_FB
default 2
+config VIDEO_FB_SPLASHSCREEN
+ bool "Enable Splashscreen when Framebuffer Driver is registered"
+ depends on VIDEO_FB
+ default n
+ ---help---
+ This feature allows a splashscreen image to be displayed during the
+ Framebuffer device driver register function. It provides the
following
+ functionality:
+ - Choice of 80x80, 160x160 or 320x320 default "NX" logos
+ - Alternative "out-of-tree" image as splashscreen
+ - Configurable background colour (default black)
+ - Bit-per-pixel choice (32/24/16/8/Greyscale/Mono) to suit the
LCD used
+ - Splashscreen can be set to remain displayed for 'n' seconds
('n' can be 0)
+ - Splashscreen can be cleared (to black) once framebuffer
device register is
+ complete
+ - Python "splashscreen_converter.py" tool (in NuttX tools
directory) can be used
+ to create custom splashscreens - note the tool restricts the
number of colours
+ to 256.
+
+
+if VIDEO_FB_SPLASHSCREEN
+
+menu "Splashscreen Image Selection and Configuration"
+
+choice
+ prompt "Select Splashscreen Image Source"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO
+ bool "Use default NuttX NX Logo"
+
+config VIDEO_FB_SPLASHSCREEN_CUSTOM
+ bool "Use Custom file as splashscreen"
Review Comment:
remove spaces and add a tab (line 91)
##########
drivers/video/Kconfig:
##########
@@ -56,6 +56,102 @@ config VIDEO_FB_NPOLLWAITERS
depends on VIDEO_FB
default 2
+config VIDEO_FB_SPLASHSCREEN
+ bool "Enable Splashscreen when Framebuffer Driver is registered"
+ depends on VIDEO_FB
+ default n
+ ---help---
+ This feature allows a splashscreen image to be displayed during the
+ Framebuffer device driver register function. It provides the
following
+ functionality:
+ - Choice of 80x80, 160x160 or 320x320 default "NX" logos
+ - Alternative "out-of-tree" image as splashscreen
+ - Configurable background colour (default black)
+ - Bit-per-pixel choice (32/24/16/8/Greyscale/Mono) to suit the
LCD used
+ - Splashscreen can be set to remain displayed for 'n' seconds
('n' can be 0)
+ - Splashscreen can be cleared (to black) once framebuffer
device register is
+ complete
+ - Python "splashscreen_converter.py" tool (in NuttX tools
directory) can be used
+ to create custom splashscreens - note the tool restricts the
number of colours
+ to 256.
+
+
+if VIDEO_FB_SPLASHSCREEN
+
+menu "Splashscreen Image Selection and Configuration"
+
+choice
+ prompt "Select Splashscreen Image Source"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO
+ bool "Use default NuttX NX Logo"
+
+config VIDEO_FB_SPLASHSCREEN_CUSTOM
+ bool "Use Custom file as splashscreen"
+ ---help---
+ This must be a compiled C source file, such as fb_splash.o, created
+ as a c src file using the splashscreen_converter.py Python script,
+ available in the nuttx/tools directory, and compiled as part of the
+ build.
+ Typically this would be a source file of an out-of-tree custom board.
Review Comment:
remove spaces and add two tabs (lines 93 to 97)
##########
drivers/video/Kconfig:
##########
@@ -56,6 +56,102 @@ config VIDEO_FB_NPOLLWAITERS
depends on VIDEO_FB
default 2
+config VIDEO_FB_SPLASHSCREEN
+ bool "Enable Splashscreen when Framebuffer Driver is registered"
+ depends on VIDEO_FB
+ default n
+ ---help---
+ This feature allows a splashscreen image to be displayed during the
+ Framebuffer device driver register function. It provides the
following
+ functionality:
+ - Choice of 80x80, 160x160 or 320x320 default "NX" logos
+ - Alternative "out-of-tree" image as splashscreen
+ - Configurable background colour (default black)
+ - Bit-per-pixel choice (32/24/16/8/Greyscale/Mono) to suit the
LCD used
+ - Splashscreen can be set to remain displayed for 'n' seconds
('n' can be 0)
+ - Splashscreen can be cleared (to black) once framebuffer
device register is
+ complete
+ - Python "splashscreen_converter.py" tool (in NuttX tools
directory) can be used
+ to create custom splashscreens - note the tool restricts the
number of colours
+ to 256.
+
+
+if VIDEO_FB_SPLASHSCREEN
+
+menu "Splashscreen Image Selection and Configuration"
+
+choice
+ prompt "Select Splashscreen Image Source"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO
+ bool "Use default NuttX NX Logo"
+
+config VIDEO_FB_SPLASHSCREEN_CUSTOM
+ bool "Use Custom file as splashscreen"
+ ---help---
+ This must be a compiled C source file, such as fb_splash.o, created
+ as a c src file using the splashscreen_converter.py Python script,
+ available in the nuttx/tools directory, and compiled as part of the
+ build.
+ Typically this would be a source file of an out-of-tree custom board.
+
+endchoice
+
+choice
+ prompt "Select NXlogo bitmap size to use"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO_160
+ depends on VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO_320
+ bool "320x320 pixels"
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO_160
+ bool "160x160 pixels"
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO_80
+ bool "80x80 pixels"
Review Comment:
remove spaces and add a tab (line 113)
##########
drivers/video/Kconfig:
##########
@@ -56,6 +56,102 @@ config VIDEO_FB_NPOLLWAITERS
depends on VIDEO_FB
default 2
+config VIDEO_FB_SPLASHSCREEN
+ bool "Enable Splashscreen when Framebuffer Driver is registered"
+ depends on VIDEO_FB
+ default n
+ ---help---
+ This feature allows a splashscreen image to be displayed during the
+ Framebuffer device driver register function. It provides the
following
+ functionality:
+ - Choice of 80x80, 160x160 or 320x320 default "NX" logos
+ - Alternative "out-of-tree" image as splashscreen
+ - Configurable background colour (default black)
+ - Bit-per-pixel choice (32/24/16/8/Greyscale/Mono) to suit the
LCD used
+ - Splashscreen can be set to remain displayed for 'n' seconds
('n' can be 0)
+ - Splashscreen can be cleared (to black) once framebuffer
device register is
+ complete
+ - Python "splashscreen_converter.py" tool (in NuttX tools
directory) can be used
+ to create custom splashscreens - note the tool restricts the
number of colours
+ to 256.
+
+
+if VIDEO_FB_SPLASHSCREEN
+
+menu "Splashscreen Image Selection and Configuration"
+
+choice
+ prompt "Select Splashscreen Image Source"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO
+ bool "Use default NuttX NX Logo"
+
+config VIDEO_FB_SPLASHSCREEN_CUSTOM
+ bool "Use Custom file as splashscreen"
+ ---help---
+ This must be a compiled C source file, such as fb_splash.o, created
+ as a c src file using the splashscreen_converter.py Python script,
+ available in the nuttx/tools directory, and compiled as part of the
+ build.
+ Typically this would be a source file of an out-of-tree custom board.
+
+endchoice
+
+choice
+ prompt "Select NXlogo bitmap size to use"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO_160
+ depends on VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO_320
+ bool "320x320 pixels"
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO_160
+ bool "160x160 pixels"
Review Comment:
remove spaces and add a tab (line 110)
##########
drivers/video/Kconfig:
##########
@@ -56,6 +56,102 @@ config VIDEO_FB_NPOLLWAITERS
depends on VIDEO_FB
default 2
+config VIDEO_FB_SPLASHSCREEN
+ bool "Enable Splashscreen when Framebuffer Driver is registered"
+ depends on VIDEO_FB
+ default n
+ ---help---
+ This feature allows a splashscreen image to be displayed during the
+ Framebuffer device driver register function. It provides the
following
+ functionality:
+ - Choice of 80x80, 160x160 or 320x320 default "NX" logos
+ - Alternative "out-of-tree" image as splashscreen
+ - Configurable background colour (default black)
+ - Bit-per-pixel choice (32/24/16/8/Greyscale/Mono) to suit the
LCD used
+ - Splashscreen can be set to remain displayed for 'n' seconds
('n' can be 0)
+ - Splashscreen can be cleared (to black) once framebuffer
device register is
+ complete
+ - Python "splashscreen_converter.py" tool (in NuttX tools
directory) can be used
+ to create custom splashscreens - note the tool restricts the
number of colours
+ to 256.
+
+
+if VIDEO_FB_SPLASHSCREEN
+
+menu "Splashscreen Image Selection and Configuration"
+
+choice
+ prompt "Select Splashscreen Image Source"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO
+
+config VIDEO_FB_SPLASHSCREEN_NXLOGO
+ bool "Use default NuttX NX Logo"
+
+config VIDEO_FB_SPLASHSCREEN_CUSTOM
+ bool "Use Custom file as splashscreen"
+ ---help---
+ This must be a compiled C source file, such as fb_splash.o, created
+ as a c src file using the splashscreen_converter.py Python script,
+ available in the nuttx/tools directory, and compiled as part of the
+ build.
+ Typically this would be a source file of an out-of-tree custom board.
+
+endchoice
+
+choice
+ prompt "Select NXlogo bitmap size to use"
+ default VIDEO_FB_SPLASHSCREEN_NXLOGO_160
+ depends on VIDEO_FB_SPLASHSCREEN_NXLOGO
Review Comment:
remove spaces and add a tab (lines 102 to 104)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
