nuttxpr commented on PR #16263: URL: https://github.com/apache/nuttx/pull/16263#issuecomment-2830318433
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a summary and testing information, it lacks crucial details and formatting. Here's a breakdown of what's missing: * **Summary:** While the summary explains the *what* and *why*, it's missing the *how*. It mentions re-enabling the MMU and per-CPU MMU tables, but doesn't explain the exact code changes made to achieve this. It also lacks links to related NuttX issues. * **Impact:** While it mentions some impact on the build and the qemu-virt arm-v7a board, it's incomplete. It needs explicit "YES/NO" answers for *all* impact categories, along with detailed descriptions for any "YES" responses. For instance, what changes are required in the build process? Are any architectures besides ARM affected? Does this impact any existing drivers? Does this fix require documentation updates? Are there any security considerations due to enabling the MMU again? What are the forward/backward compatibility implications? * **Testing:** The testing section is insufficient. It mentions CI and a local project but doesn't provide specific details required by the template: * **Build Host(s):** Needs specific details about the development environment (OS, CPU, compiler versions used). * **Target(s):** Needs specific details about the target architecture (e.g., `qemu-system-arm -M virt`), board configuration, and NuttX configuration (e.g., `knsh_smp`). * **Logs:** Critically, the template requires "before" and "after" logs demonstrating the issue and the fix. Just stating "CI-test" doesn't provide evidence of the fix. **Example of improvements for the Testing section:** ``` ## Testing I confirm that changes are verified on local setup and works as intended: * Build Host(s): Ubuntu 22.04, x86_64, GCC 11.2.0 * Target(s): qemu-system-arm -M virt, `configs/qemu-armv7a/knsh_smp` Testing logs before change: ``` <paste log showing the kernel-smp failure in qemu-virt arm-v7a. Show the specific error message or behavior.> ``` Testing logs after change: ``` <paste log demonstrating the SMP functionality working correctly after the changes. Show output from all CPUs or other evidence of SMP operation.> ``` ``` By addressing these missing details and following the template closely, the PR will be much easier for reviewers to understand and approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
