xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2056266614
########## include/nuttx/mutex.h: ########## @@ -36,10 +36,11 @@ * Pre-processor Definitions ****************************************************************************/ -#define NXMUTEX_NO_HOLDER ((pid_t)-1) -#define NXMUTEX_INITIALIZER {NXSEM_INITIALIZER(1, SEM_TYPE_MUTEX | \ - SEM_PRIO_INHERIT), NXMUTEX_NO_HOLDER} -#define NXRMUTEX_INITIALIZER {NXMUTEX_INITIALIZER, 0} +#define NXMUTEX_INITIALIZER { \ + NXSEM_INITIALIZER(NXMUTEX_NO_HOLDER, SEM_TYPE_MUTEX | SEM_PRIO_INHERIT), \ + NXMUTEX_NO_HOLDER} Review Comment: it's fine if the new change hold in a new patch, I want to see the final result which is more clean and understandable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org