acassis commented on code in PR #16244: URL: https://github.com/apache/nuttx/pull/16244#discussion_r2054042099
########## arch/arm/src/rp23xx/rp23xx_start.c: ########## @@ -86,8 +87,13 @@ void __start(void) #ifdef CONFIG_BOOT_RUNFROMFLASH const uint32_t *src; #endif - uint32_t *dest; - int i; + uint32_t *dest; + int i; + const uint8_t safe_spinlocks[] = { + 5, 6, 7, 10, 11, 18, 19, + 20, 21, 22, 23, 24, 25, 26, + 27, 28, 29, 30, 31 + }; Review Comment: @shtirlic Please include a comment here in the code as well explaining the reason, it is easier than searching for which commit added it and why. Also move the brackets to the next line: https://nuttx.apache.org/docs/latest/contributing/coding_style.html#braces -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org