shtirlic commented on code in PR #16244: URL: https://github.com/apache/nuttx/pull/16244#discussion_r2053517978
########## arch/arm/src/rp23xx/rp23xx_testset.c: ########## @@ -36,7 +36,13 @@ * Pre-processor Definitions ****************************************************************************/ -#define RP23XX_TESTSET_SPINLOCK 0 /* Spinlock used for test and set */ +/* Errata RP2350-E2 SIO SPINLOCK writes are mirrored at +0x80 offset + * Use only safe SPINLOCKS + * The following SIO spinlocks can be used normally as they do not alias + * with writable registers: 5, 6, 7, 10,11, and 18 through 31. + */ + +#define RP23XX_TESTSET_SPINLOCK 7 /* Spinlock used for test and set */ Review Comment: It was there before and used in `up_testset` function, I've changed the number only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
