keever50 commented on code in PR #16024:
URL: https://github.com/apache/nuttx/pull/16024#discussion_r2007083751
##########
include/nuttx/wireless/ioctl.h:
##########
@@ -48,67 +48,214 @@
* the open() interface.
****************************************************************************/
-#define WLIOC_SETRADIOFREQ _WLCIOC(0x0001) /* arg: Pointer to uint32_t, */
- /* frequency value (in MHz) */
-#define WLIOC_GETRADIOFREQ _WLCIOC(0x0002) /* arg: Pointer to uint32_t, */
- /* frequency value (in MHz) */
-#define WLIOC_SETADDR _WLCIOC(0x0003) /* arg: Pointer to address value,
format
- * of the address is driver
specific */
-#define WLIOC_GETADDR _WLCIOC(0x0004) /* arg: Pointer to address value,
format
- * of the address is driver
specific */
-#define WLIOC_SETTXPOWER _WLCIOC(0x0005) /* arg: Pointer to int32_t, */
- /* output power (in 0.01 dBm) */
-#define WLIOC_GETTXPOWER _WLCIOC(0x0006) /* arg: Pointer to int32_t, */
- /* output power (in 0.01 dBm) */
+/****************************************************************************
+ * RF common IOCTL commands
+ ****************************************************************************/
+
+/* Offsets */
+
+#define _WLIOC_COM_OFFS 1
+#define _WLIOC_COM(x) _WLCIOC(_WLIOC_COM_OFFS+x)
+
+/* Commands */
+
+#define WLIOC_SETRADIOFREQ _WLIOC_COM(0) /* arg: Pointer to uint32_t, */
+ /* frequency value (in Hz) */
+#define WLIOC_GETRADIOFREQ _WLIOC_COM(1) /* arg: Pointer to uint32_t, */
+ /* frequency value (in Hz) */
+
+#define WLIOC_SETADDR _WLIOC_COM(2) /* arg: Pointer to address value,
format
+ * of the address is driver specific
*/
+#define WLIOC_GETADDR _WLIOC_COM(3) /* arg: Pointer to address value,
format
+ * of the address is driver specific
*/
+
+#define WLIOC_SETTXPOWER _WLIOC_COM(4) /* arg: Pointer to int32_t, */
+ /* Set output power in dBm */
+#define WLIOC_GETTXPOWER _WLIOC_COM(5) /* arg: Pointer to int32_t, */
+ /* Get output power in dBm */
+
+#define WLIOC_SETFINEPOWER _WLIOC_COM(6) /* arg: Pointer to int32_t,
+ * Set power in steps of 0.01 dBm */
+#define WLIOC_GETFINEPOWER _WLIOC_COM(7) /* arg: Pointer to int32_t,
+ * Get power in steps of 0.01 dBm */
+
+#define WLIOC_SETMODU _WLIOC_COM(8) /* arg: Pointer to enum
wlioc_modulation_e.
+ * This sets the modulation
technology. */
+#define WLIOC_GETMODU _WLIOC_COM(9) /* arg: Pointer to enum
wlioc_modulation_e.
+ * Get current modulation
technology. */
+
+/* Number of commands */
+
+#define _WLIOC_COM_COMMANDS 10 /* ! Must be corrected after changes to
commands.
+ * ! Equal to the amount of commands above. */
+
+/****************************************************************************
+ * LoRa common IOCTL commands
+ ****************************************************************************/
+
+/* Offsets */
+
+#define _WLIOC_LORA_OFFS _WLIOC_COM_OFFS+_WLIOC_COM_COMMANDS
+#define _WLIOC_LORA(x) _WLCIOC(_WLIOC_LORA_OFFS+x)
+
+/* Commands */
+
+#define WLIOC_LORA_SETSF _WLIOC_LORA(0) /* arg: Pointer to uint8_t */
+ /* Spreading factor */
+#define WLIOC_LORA_GETSF _WLIOC_LORA(1) /* arg: Pointer to uint8_t */
+ /* Spreading factor */
+
+#define WLIOC_LORA_SETBW _WLIOC_LORA(2) /* arg: Pointer to uint32_t */
+ /* Bandwidth Hz */
+#define WLIOC_LORA_GETBW _WLIOC_LORA(3) /* arg: Pointer to uint32_t */
+ /* Bandwidth Hz */
+
+#define WLIOC_LORA_SETCR _WLIOC_LORA(4) /* arg: Pointer to
wlioc_lora_cr_e */
+ /* Coding rate */
+#define WLIOC_LORA_GETCR _WLIOC_LORA(5) /* arg: Pointer to
wlioc_lora_cr_e */
+ /* Coding rate */
+
+#define WLIOC_LORA_SETCRC _WLIOC_LORA(6) /* arg: Pointer to uint8_t */
+ /* Enable/disable CRC */
+#define WLIOC_LORA_GETCRC _WLIOC_LORA(7) /* arg: Pointer to uint8_t */
+ /* Enabled/disabled CRC */
+
+#define WLIOC_LORA_SETFIXEDHDR _WLIOC_LORA(8) /* arg: Pointer to uint8_t */
+ /* Enable/disable length byte */
+#define WLIOC_LORA_GETFIXEDHDR _WLIOC_LORA(9) /* arg: Pointer to uint8_t */
+ /* Enabled/disabled length byte
*/
+
+#define WLIOC_LORA_SETSYNCWORD _WLIOC_LORA(10) /* arg: Pointer to
wlioc_lora_syncword_s */
+ /* Sets custom length syncword
*/
+#define WLIOC_LORA_GETSYNCWORD _WLIOC_LORA(11) /* arg: Pointer to
wlioc_lora_syncword_s */
+ /* Gets custom length syncword
*/
+
+/* Number of commands */
+
+#define _WLIOC_LORA_COMMANDS 12 /* ! Must be corrected after changes to
commands.
+ * ! Equal to the amount of commands above.
*/
+
+/****************************************************************************
+ * FSK common IOCTL commands (Including GFSK and similar)
+ ****************************************************************************/
+
+/* Offsets. Must follow WLIOC_LORA */
+
+#define _WLIOC_FSK_OFFS _WLIOC_LORA_OFFS+_WLIOC_LORA_COMMANDS
+#define _WLIOC_FSK(x) _WLCIOC(_WLIOC_FSK_OFFS+x)
+
+/* Commands */
+
+#define WLIOC_FSK_SETBITRATE _WLIOC_FSK(0) /* arg: uint32_t ptr */
+ /* In bits per second */
+#define WLIOC_FSK_GETBITRATE _WLIOC_FSK(1) /* arg: uint32_t ptr */
+ /* In bits per second */
+
+#define WLIOC_FSK_SETFDEV _WLIOC_FSK(2) /* arg: uint32_t ptr */
+ /* Frequency deviation Hz */
+#define WLIOC_FSK_GETFDEV _WLIOC_FSK(3) /* arg: uint32_t ptr */
+ /* Frequency deviation Hz */
+
+/* Number of commands */
+
+#define _WLIOC_FSK_COMMANDS 4 /* ! Must be corrected after changes to
commands.
+ * ! Equal to the amount of commands
above. */
+
+/****************************************************************************
+ * OOK (Also called "binary" ASK) common IOCTL commands
+ ****************************************************************************/
+
+/* Offsets. Must follow WLIOC_FSK */
+
+#define _WLIOC_OOK_OFFS _WLIOC_FSK_OFFS+_WLIOC_FSK_COMMANDS
+#define _WLIOC_OOK(x) _WLCIOC(_WLIOC_OOK_OFFS+x)
+
+/* Commands */
+
+#define WLIOC_OOK_SETBITRATE _WLIOC_OOK(0) /* arg: uint32_t ptr */
+ /* In bits per second */
+#define WLIOC_OOK_GETBITRATE _WLIOC_OOK(1) /* arg: uint32_t ptr */
+ /* In bits per second */
+
+/* Number of commands */
+
+#define _WLIOC_OOK_COMMANDS 2 /* ! Must be corrected after changes to
commands.
+ * ! Equal to the amount of commands
above. */
+
+/****************************************************************************
+ * Device-specific IOCTL commands
+ ****************************************************************************/
/* WARNING: The following WLIOC command are EXPERIMENTAL and unstable. They
* may be removed or modified in upcoming changes that introduce a common
* LoRa API. These commands are currently only used by the RN2XX3 driver.
*/
-#define WLIOC_SETBANDWIDTH _WLCIOC(0x0007) /* arg: Pointer to uint32_t, */
+/* Offsets. Must follow WLIOC_OOK */
+
+#define _WLIOC_RN2XX3_OFFS _WLIOC_OOK_OFFS+_WLIOC_OOK_COMMANDS
+#define _WLIOC_RN2XX3(x) _WLCIOC(_WLIOC_RN2XX3_OFFS+x)
+
+/* Commands */
+
+#define WLIOC_SETBANDWIDTH _WLIOC_RN2XX3(0) /* arg: Pointer to uint32_t, */
/* bandwidth in Hz */
-#define WLIOC_GETBANDWIDTH _WLCIOC(0x0008) /* arg: Pointer to uint32_t, */
+#define WLIOC_GETBANDWIDTH _WLIOC_RN2XX3(1) /* arg: Pointer to uint32_t, */
/* bandwidth in Hz */
-#define WLIOC_SETSPREAD _WLCIOC(0x0009) /* arg: Pointer to uint8_t, */
+
+#define WLIOC_SETSPREAD _WLIOC_RN2XX3(2) /* arg: Pointer to uint8_t, */
/* spread factor */
-#define WLIOC_GETSPREAD _WLCIOC(0x000a) /* arg: Pointer to uint8_t, */
+#define WLIOC_GETSPREAD _WLIOC_RN2XX3(3) /* arg: Pointer to uint8_t, */
/* spread factor */
-#define WLIOC_GETSNR _WLCIOC(0x000b) /* arg: Pointer to int8_t, */
+
+#define WLIOC_GETSNR _WLIOC_RN2XX3(4) /* arg: Pointer to int8_t, */
/* signal to noise ratio */
-#define WLIOC_SETPRLEN _WLCIOC(0x000c) /* arg: uint16_t, */
+
+#define WLIOC_SETPRLEN _WLIOC_RN2XX3(5) /* arg: uint16_t, */
/* preamble length */
-#define WLIOC_GETPRLEN _WLCIOC(0x000d) /* arg: Pointer to uint16_t, */
+#define WLIOC_GETPRLEN _WLIOC_RN2XX3(6) /* arg: Pointer to uint16_t, */
/* preamble length */
-#define WLIOC_SETMOD _WLCIOC(0x000e) /* arg: enum, */
+
+#define WLIOC_SETMOD _WLIOC_RN2XX3(7) /* arg: enum, */
/* modulation type */
-#define WLIOC_GETMOD _WLCIOC(0x000f) /* arg: enum pointer, */
+#define WLIOC_GETMOD _WLIOC_RN2XX3(8) /* arg: enum pointer, */
/* modulation type */
-#define WLIOC_RESET _WLCIOC(0x0010) /* arg: none */
-#define WLIOC_SETSYNC _WLCIOC(0x0011) /* arg: uint64_t pointer */
- /* sync word */
-#define WLIOC_GETSYNC _WLCIOC(0x0012) /* arg: uint64_t pointer, */
- /* sync word */
-#define WLIOC_SETBITRATE _WLCIOC(0x0013) /* arg: uint32_t */
- /* sync word */
-#define WLIOC_GETBITRATE _WLCIOC(0x0014) /* arg: uint32_t pointer, */
- /* sync word */
-#define WLIOC_IQIEN _WLCIOC(0x0015) /* arg: bool, enable invert IQ */
-#define WLIOC_CRCEN _WLCIOC(0x0016) /* arg: bool, enable CRC */
-#define WLIOC_SETCODERATE _WLCIOC(0x0017) /* arg: enum, coding rate */
-#define WLIOC_GETCODERATE _WLCIOC(0x0018) /* arg: enum pointer, */
- /* coding rate */
-#define WLIOC_SETTXPOWERF _WLCIOC(0x0019) /* arg: Pointer to flaot, */
- /* output power (in dBm) */
-#define WLIOC_GETTXPOWERF _WLCIOC(0x0020) /* arg: Pointer to float, */
- /* output power (in dBm) */
-/****************************************************************************
- * Device-specific IOCTL commands
- ****************************************************************************/
+#define WLIOC_RESET _WLIOC_RN2XX3(9) /* arg: none */
Review Comment:
No, this will likely be removed entirely. Or at least what remains must be
moved to the chip header. It also has conflicting commands. I don't want to
touch it yet.
This can be done by the developer of this chip. See the GitHub issue.
I highly prefer to wait for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
