acassis commented on PR #16016: URL: https://github.com/apache/nuttx/pull/16016#issuecomment-2737704768
> I don't know why, @acassis , but I couldn't continue the thread of [#16016 (comment)](https://github.com/apache/nuttx/pull/16016#discussion_r2003977861). > > > Wouldn't it better to get ESP32 as more register direct access instead of using the HAL? AFAIK only esp32_userspace_pid.c is using the HAL currently. > > No, currently, all the common drivers under `nuttx/arch/xtensa/src/common/espressif` use the common layer (`_ll.h` header files). This is valid for ESP32 too. > > > I suggest keep this driver as he implemented. > > There were two types of suggestions I've made: [#16016 (comment)](https://github.com/apache/nuttx/pull/16016#discussion_r2003163566), for instance, is highly recommended because we don't use literal addresses (even for the so-called "register-level" access). All of the suggestions (except [#16016 (review)](https://github.com/apache/nuttx/pull/16016#pullrequestreview-2698141701)) belongs to this category. **Apart from that**, I suggested using the `_ll.h` functions (instead of directly writing to the registers in the driver) to enable this driver to be moved to `nuttx/arch/xtensa/src/common/espressif` and be used in the future for other devices. We can help that. > > This last suggestion is not mandatory. This is an open-source project and people may prefer to implement it the way they are more comfortable. However, we won't support it when we have a common driver implemented for the other devices, so that's why I suggested to adapt it to be more future-proof. Makes sense! Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
