Laczen commented on code in PR #15978:
URL: https://github.com/apache/nuttx/pull/15978#discussion_r1992082987
##########
net/udp/udp_input.c:
##########
@@ -348,28 +348,35 @@ static int udp_input(FAR struct net_driver_s *dev,
unsigned int iplen)
* unless destination address was broadcast/multicast.
*/
-#if defined(CONFIG_NET_ICMP) || defined(CONFIG_NET_ICMPv6)
Review Comment:
> could you keep the original code layout? it's hard to find the real change
with the new layout
The original code layout was hiding a bug (IPv4 enabled, IPv6 enabled, ICMP
enabled and ICMPv6 disabled) a ICMP return would be created for IPv6. By
changing the code layout I tried to make it more clear. I agree that it is
quite difficult to review from the changes view, it is easier to look at the
final code instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
