anchao commented on PR #15959: URL: https://github.com/apache/nuttx/pull/15959#issuecomment-2709355934
> Thanks @anchao :-) Could you please write some more details why this change is necessary and what it solves / fixes / improves? Just merge wdog_periods_s into wdog_s , individual developers don't need to learn whether to use wdog_periods_s or wdog_s > You often introduce changes in critical parts of the RTOS but with not much explanation why. Single sentence on what you change is not enough, we can see that in the code, but we also need to know WHY. It is important to explain the motivation behind the change to other people and that would help in review. original author of this feature is not me, I carried out some refined tweaks of the code. > You say "Make wdog support period semantics by default, avoid exposing two structures to enhance consistency". Consistency with what? Implementations on other OS/RTOS? Removes code that is not always necessary / used to decrease firmware size? you should raise the question to https://github.com/apache/nuttx/pull/15937 > Current split design looks on purpose? Have you checked what targets will be affected by this change? If so where is the check presented? ditto > What if some people use that code as it is now.. it will be broken for them.. and it would be nice to know WHY. this feature was merged just 2 days ago, why don't you raise these questions before #15937 merged? https://github.com/apache/nuttx/pull/15937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
