cederom commented on PR #3011: URL: https://github.com/apache/nuttx-apps/pull/3011#issuecomment-2692513068
> @txy-21: Thank you @cederom :-) In the previous discussion, I thought that the framework should be stored in apps/tests, and the specific cmocka test cases should be placed in the corresponding category under testing and named "category/basic", isn't that right? These cmocka cases are missing cmakelist.txt, I will add it later. Are you moving test scenarios (tests to be performed that return PASS/FAIL) or testing framework (some tool that is required to run the tests) @txy-21 ? :-) If test scenarios then correct location is `apps/tests/...` if testing framework then `apps/testing/...`. I think the conclusion was to separate testing frameworks / tools from test scenarios. I can see mix of several things here that may need clarification / separation: 1. `TESTS_TESTSUITES` is described as "vela test suite". Why not use `TESTS_VELA_SUITE` then (or similar `TESTS_CMOCKA_SUITE`)? 2. As this seems Vela Test Suite shouldn't location be `apps/testing/vela` (or similar if this is Cmocka Test Suite then `apps/testing/cmocka`) ? 3. Renamed `c` and `h` files are in facts tests, right? If so these should be placed in `apps/tests` but not along test suite `apps/testing` right? 4. If these FS tests require cmocka / vela test suite then it would be best to put cmocka framework in `apps/testing/cmocka` and/or vela framework in `apps/testing/vela`, then group all cmocka tests in `apps/tests/cmocka` for instance FS tests in `apps/tests/cmocka/fs` so it is clear that these are test cases that require cmocka and are dedicated for filesystem? What do you thinkg @raiden00pl @xiaoxiang781216 was that your thought? Is it doable to put Cmocka Framework in `apps/testing/cmocka` and cmocka tests in `apps/tests/cmocka` ? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
