nuttxpr commented on PR #3011: URL: https://github.com/apache/nuttx-apps/pull/3011#issuecomment-2685396578
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides some information, it lacks crucial details. Here's a breakdown: * **Insufficient Summary:** While it states *what* is changed, it doesn't explain *why*. What problem does moving `cmocka_fs` solve? What are the benefits? How does the move work (e.g., just moving files, or code changes within the tests themselves)? There's no mention of related issues. * **Incomplete Impact Assessment:** Simply listing affected directories isn't enough. Consider these questions: * **New/Changed Feature:** Is this just a reorganization or does it affect functionality? * **User Impact:** Likely no, but explicitly state it. * **Build Impact:** Will anything need to be changed in Makefiles or configuration? * **Hardware Impact:** Likely no, but explicitly state it. * **Documentation Impact:** Does this change require updating any documentation (e.g., test suite organization)? * **Security Impact:** Likely no, but explicitly state it. * **Compatibility Impact:** Likely no, but explicitly state it. * **Missing Testing Details:** "ci test" isn't sufficient. Provide specific details: * **Build Host:** OS, CPU architecture, compiler version. * **Target:** Architecture (e.g., simulator, specific hardware), board and configuration. * **Logs:** Actual *before* and *after* logs demonstrating the change's effect (or explain why logs are not applicable, if that's the case). Just saying "ci test" doesn't show *what* was tested or the *results* of the test. The PR description needs to be much more thorough to meet the NuttX requirements. Provide the missing context and details to make it clear why the change is necessary and that it has been properly validated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
