anchao commented on code in PR #15842:
URL: https://github.com/apache/nuttx/pull/15842#discussion_r1957481709
##########
drivers/i2c/i2c_slave_driver.c:
##########
@@ -506,9 +506,12 @@ static int i2c_slave_callback(FAR void *arg,
i2c_slave_complete_t status,
priv->read_index = 0;
priv->read_length = length;
- while (nxsem_get_value(&priv->wait, &semcount) >= 0 && semcount <= 0)
+ if (nxsem_get_value(&priv->wait, &semcount) >= 0)
{
- nxsem_post(&priv->wait);
+ while (semcount <= 0)
Review Comment:
```suggestion
while (semcount++ <= 0)
```
and hold the sched_lock() around is loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
