nuttxpr commented on PR #15789: URL: https://github.com/apache/nuttx/pull/15789#issuecomment-2644521538
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR substantially meets the NuttX requirements. The summary clearly explains the change, its scope (limited support), and mentions accompanying documentation. The impact section identifies affected parts (build system, kernel) and correctly notes the addition of a new driver as a feature. The testing section is comprehensive, detailing the host and target environments, providing the test script, expected behavior, observed output in different modes (interrupt/polling), and even includes relevant system logs. This thorough testing significantly strengthens the PR. Minor suggestions for improvement: * **Explicitly state "YES" or "NO" for each Impact item:** Even though the general impact is described, going through each specific point (user impact, build impact, etc.) and marking them with YES/NO improves clarity and ensures nothing is overlooked. For instance, explicitly stating "Impact on user: YES (Users can now use the LSM6DSO32 IMU via uORB)" would be beneficial. For any "YES" responses, provide concise descriptions as the template requests. * **Conciseness in Testing:** While comprehensive testing is good, the testing logs could be trimmed down. Focus on key parts that demonstrate functionality and address potential issues, rather than including the entire output. Summaries and specific excerpts would be more effective. For example, showing the change in full-scale range and a few measurements before/after would suffice. * **NuttX Issue Reference:** If this PR addresses a specific issue in the NuttX repository, including a link would be helpful for tracking. By addressing these minor points, the PR will even more closely adhere to the NuttX requirements and be easier for reviewers to assess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
