xiaoxiang781216 commented on code in PR #15729: URL: https://github.com/apache/nuttx/pull/15729#discussion_r1936699671
########## include/nuttx/spinlock.h: ########## @@ -456,7 +456,7 @@ irqstate_t raw_spin_lock_irqsave(FAR volatile spinlock_t *lock) irqstate_t flags; flags = up_irq_save(); - raw_spin_lock(lock); + spin_lock_prempt(lock); Review Comment: all raw_ need be renamed to _prempt ########## include/nuttx/spinlock.h: ########## @@ -241,7 +241,7 @@ static inline_function void spin_lock(FAR volatile spinlock_t *lock) Review Comment: let's move sched_note to spin_lock_prempt ########## include/nuttx/spinlock.h: ########## @@ -456,7 +456,7 @@ irqstate_t raw_spin_lock_irqsave(FAR volatile spinlock_t *lock) irqstate_t flags; flags = up_irq_save(); - raw_spin_lock(lock); + spin_lock_prempt(lock); Review Comment: raw_spin_lock_irqsave need change to spin_lock_irqsave_prempt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
