anchao commented on PR #15603:
URL: https://github.com/apache/nuttx/pull/15603#issuecomment-2604384099
> > > i guess the main disagreement between us is on how large the overhead
is. anchao seems to think it important. i feel it's negligible. none of us
provided any numbers. maybe i can do some simple benchmark later.
> >
> >
> > read test on sim/nsh ubuntu 24.04:
>
> thank you for the benchmark. what cpu is it? x86-64? "without your patch"
is this PR and "with your patch" is the base version of this PR?
>what cpu is it? x86-64?
Yes
```
$ cat /proc/cpuinfo
processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 151
model name : 12th Gen Intel(R) Core(TM) i7-12700K
stepping : 2
microcode : 0x37
cpu MHz : 2426.043
cache size : 25600 KB
physical id : 0
siblings : 20
core id : 0
cpu cores : 12
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 32
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge
mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx
pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl
xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64
monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2
x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm
3dnowprefetch cpuid_fault epb ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow
flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms
invpcid rdseed adx smap clflushopt clwb intel_pt sha_ni xsaveopt xsavec xgetbv1
xsaves split_lock_detect user_shstk avx_vnni dtherm ida arat pln pts hwp
hwp_notify hwp_act_window hwp_epp hwp_pkg_req hfi vnmi umip pku ospke waitpkg
gfni vaes vpclmulqdq tme rdpid movdiri movdir64b fsrm md_clear serialize
pconfig arch_lbr ibt flush_l1d arch_capabilities
vmx flags : vnmi preemption_timer posted_intr invvpid ept_x_only ept_ad
ept_1gb flexpriority apicv tsc_offset vtpr mtf vapic ept vpid
unrestricted_guest vapic_reg vid ple shadow_vmcs ept_mode_based_exec
tsc_scaling usr_wait_pause
bugs : spectre_v1 spectre_v2 spec_store_bypass swapgs eibrs_pbrsb
rfds bhi
bogomips : 7219.20
clflush size : 64
cache_alignment : 64
address sizes : 46 bits physical, 48 bits virtual
power management:
...
```
>"without your patch" is this PR and "with your patch" is the base version
of this PR?
I just revert writev/readv refactor code:
```
commit 742865af87ac59bdaf6198c812a475fb02840d31 (HEAD)
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:02:07 2025 +0800
Revert "fs/vfs: Fix initialization of `g_pseudofile_ops`"
This reverts commit 0702dc536172b73e05a45fe7539ff3df4943ff6d.
commit 665db310055aec9cf9a419229cd94b241a63218d
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:01:19 2025 +0800
Revert "move readv/writev to the kernel"
This reverts commit 761ee819568a52f1934ccf17bae20fe9816ebdec.
commit 572c813e2bba95bd89fcd7e1afa639d7cf0c25ab
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:00:51 2025 +0800
Revert "file_readv_compat/file_writev_compat: Fix partial success
handling"
This reverts commit 8241a10ebcc259d4b9a9a82337d7124514ffeabd.
commit 38db4703e6f9d94f0b29c258bdc428273ec74571
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:00:42 2025 +0800
Revert "Update a few comments after the recent readv/writev changes"
This reverts commit 9a2b6be8420ca173d92632a05882e01306e2c41d.
commit eae60045f9e4305ef4e8f617c849625181451c0b
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:00:26 2025 +0800
Revert "Update a few comments after the recent readv/writev changes"
This reverts commit 2749510413d0015f4fce457de79518f1e6e22712.
commit c2920ff0b494bbf5d792c472ad5d1823a32598c6
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:00:16 2025 +0800
Revert "uio api tweaks"
This reverts commit 30ad31e9d722556b3bad34457088c3cec46cf988.
commit f927e5bf321d568a28d1cf95e3a43a9150caa031
Author: chao an <anchao.arc...@bytedance.com>
Date: Tue Jan 21 18:00:11 2025 +0800
Revert "drivers/serial/serial.c: adapt to the iovec-based api"
This reverts commit 00010089b8332592912d60e57f85f2f954905365.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
