hujun260 commented on code in PR #15426: URL: https://github.com/apache/nuttx/pull/15426#discussion_r1908382270
########## arch/arm/src/am335x/am335x_serial.c: ########## @@ -1204,7 +1216,7 @@ static void up_txint(struct uart_dev_s *dev, bool enable) struct up_dev_s *priv = (struct up_dev_s *)dev->priv; irqstate_t flags; - flags = enter_critical_section(); + flags = spin_lock_irqsave(&g_gpio_lock); Review Comment: may cause deadlock https://github.com/apache/nuttx/pull/15323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org