wangzhi-art commented on code in PR #15426: URL: https://github.com/apache/nuttx/pull/15426#discussion_r1908338998
########## arch/arm/src/am335x/am335x_i2c.c: ########## @@ -492,7 +497,7 @@ static inline int am335x_i2c_sem_waitdone(struct am335x_i2c_priv_s *priv) uint32_t regval; int ret; - flags = enter_critical_section(); + flags = spin_lock_irqsave(&priv->spinlock); Review Comment: Exit the critical section before wait and enter the critical section after wait (logically consistent with the previous recursive global lock) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
