hujun260 commented on code in PR #15138:
URL: https://github.com/apache/nuttx/pull/15138#discussion_r1879880444
##########
sched/clock/clock_adjtime.c:
##########
@@ -108,7 +109,7 @@ static int adjtime_start(long long adjust_usec)
ppb = -ppb_limit;
}
- flags = enter_critical_section();
+ flags = spin_lock_irqsave(&g_adjtime_lock);
Review Comment:
Addressing widely-used critical sections is not an easy task. now, we can
analyze the issue case by case, considering that there is a limited number of
up_xxx interfaces. We can examine the specific modifications or read operations
of the up_xxx interfaces, as well as check whether the files they are located
in use critical sections, to determine whether the modifications are safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
