nuttxpr commented on PR #15138: URL: https://github.com/apache/nuttx/pull/15138#issuecomment-2535518211
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR likely does *not* fully meet the NuttX requirements. While it provides some information, it's severely lacking in detail and completeness. Here's a breakdown of the missing pieces: * **Summary:** The "what" is described poorly. While it mentions replacing a critical section with a small lock, it doesn't explain *why* this is necessary (performance improvement, deadlock avoidance, etc.). It also lacks detail on *how* the change is implemented (what lock is used, how it integrates with existing code). There's no mention of related issues. * **Impact:** This section is almost entirely empty. Simply stating "clock_adjtime" doesn't explain the impact. All the "NO/YES" questions need to be addressed with explanations if "YES". Consider things like: Will the change affect the accuracy of timekeeping? Will existing applications using `clock_adjtime` need to be modified? Are there any performance implications? * **Testing:** "ci ostest" is insufficient. The request needs specific details: * **Build Host(s):** E.g., "Linux, x86_64, GCC 12.2.0" * **Target(s):** E.g., "qemu-rv32ima, sim:nsh" * **Testing logs:** Actual logs demonstrating the problem before the change and the improved behavior after the change. Simply saying "ci ostest" doesn't prove anything without the actual log output showing the difference. In short, the PR needs significantly more information to be considered complete. It needs to clearly explain the motivation, the implementation details, the potential impact on various aspects of the system, and provide concrete evidence that the change works as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
