nuttxpr commented on PR #15139: URL: https://github.com/apache/nuttx/pull/15139#issuecomment-2535404667
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a link to prior work and a brief explanation, it lacks crucial details. Here's what's missing: * **Summary:** Needs more detail. *How* does `up_timer_gettime()` provide higher resolution? *What* is the "wall clock diff" and *why* is its removal important? The explanation about the global clock generator is helpful, but more detail on the recalculation of ticks is needed. * **Impact:** Simply stating "N/A" is insufficient. Consider each point individually. Even if there's *no* impact, explicitly state "NO" for each category. The changes described likely impact hardware and drivers, so claiming no impact is questionable. * **Testing:** "ci-check" is not sufficient. Provide actual log output before and after the change, demonstrating the improvement. Also specify the Build Host(s) and Target(s) used for testing. Simply stating "ci-check" doesn't convey what was tested or the results. The PR needs substantial improvement in providing specific details for each of the required sections to meet the NuttX guidelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
